-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: STFT-076: Secureli ignore - ability to suppress issues - auto prompt user #18
Conversation
…eature/STFT-076-auto-suppress-failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the settings in this file actually change, lines were re-ordered as a result of the file being written programmatically instead of by hand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave you a basic approval just to unblock. If people don't like it, we can always open additional stories
STFT-076: STFT-076: Secureli ignore - ability to suppress issues - auto prompt user
This PR adds a new feature which prompts users after a scan that has resulted in a linter failure if they would like to add an ignore rule for any of the detected failures.
If the user agrees to add an ignore rule, then secureli iterates through each failure and asks the user if they want to add an ignore for that failure, if so, then it also asks if the user wants to ignore the failure for all files or a specific file.
To test this, make any change (and stage the file) that would cause a linter failure. Some simple ones would be adding some white space at the end of a line or removing the blank line at the end of a file. Any linter failure should trigger the notification.
Note: New ignore rules are detected as an available upgrade, so when you run your next scan after adding an ignore, you will want to confirm the upgrade.