Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile unit tests in multivariant libraries #667

Open
ZacSweers opened this issue Dec 4, 2023 · 0 comments
Open

Reconcile unit tests in multivariant libraries #667

ZacSweers opened this issue Dec 4, 2023 · 0 comments

Comments

@ZacSweers
Copy link
Collaborator

Currently our ciUnitTest lifecycle tasks only depend on the release variant of tests in libraries, but multi-variant libraries could run their tests in other variants too.

Let's do two things

  1. Make ciUnitTest depend on the test task and not just the release test task. This seems like a legacy holdover.
  2. Disable the non-release unit tests by default and add a property to optionally enable them if this is desirable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant