diff --git a/compose-lint-checks/lint-baseline.xml b/compose-lint-checks/lint-baseline.xml index 93e250c5..3524de72 100644 --- a/compose-lint-checks/lint-baseline.xml +++ b/compose-lint-checks/lint-baseline.xml @@ -1,14 +1,25 @@ - + + errorLine1=" Composable functions that return Unit should start with an uppercase letter." + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + + + + @@ -18,8 +29,8 @@ errorLine1=" `CompositionLocal`s are implicit dependencies and creating new ones should be avoided." errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -29,19 +40,41 @@ errorLine1=" Composable functions should either emit content into the composition or return a value, but not both." errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + + + + + + + + @@ -51,8 +84,8 @@ errorLine1=" Modifiers should only be used once and by the root level layout of a Composable. This is true even if appended to or with other modifiers e.g. `modifier.fillMaxWidth()`." errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -62,8 +95,8 @@ errorLine1=" This @Composable function has a modifier parameter but it doesn't have a default value." errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -73,8 +106,8 @@ errorLine1=" Composable functions should only be emitting content into the composition from one source at their top level." errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -84,42 +117,53 @@ errorLine1=" Using mutable objects as state in Compose will cause your users to see incorrect or stale data in your app." errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" Composables annotated with `@Preview` that are used only for previewing the UI should not be public." + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="The issue summary should be shorter; typically just a 3-6 words; it's used as a topic header in HTML reports and in the IDE inspections window" + errorLine1=" "Forwarding a ViewModel through multiple @Composable functions should be avoided"," + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + file="src/main/java/slack/lint/compose/ViewModelForwardingDetector.kt" + line="30" + column="12"/> + + + + + errorLine1=" Forwarding a ViewModel through multiple @Composable functions should be avoided. Consider using state hoisting." + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + file="src/main/java/slack/lint/compose/ViewModelForwardingDetector.kt" + line="33" + column="11"/>