Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting in content makes page scroll to top #222

Closed
sferoze opened this issue Sep 30, 2014 · 6 comments
Closed

Pasting in content makes page scroll to top #222

sferoze opened this issue Sep 30, 2014 · 6 comments

Comments

@sferoze
Copy link
Contributor

sferoze commented Sep 30, 2014

Whenever I paste in text content into the quill editor, it makes the main page scroll to the top.

So immediately after you paste content into the Quill Editor, if the main page is scrolled down, all of a sudden the page jumps to the the top of the scroll position.

Try going to the Quill homepage. Scroll the main page down some. Then scroll the quill editor documents down to the bottom and paste in some content. All of a sudden you will notice the screen jumping to the top of the page.

I am using Chrome 37 on Mac OSX Mavericks.

@sferoze
Copy link
Contributor Author

sferoze commented Oct 20, 2014

Hi @jhchen ,

I just tried the newest version of Quill v.0.18.0 and when pasting content, the page scrolls to the top and does not go back to the original position. I tested this in chrome 38.

So it is not functional to use paste in a long document as the user completely loses the position.

@jhchen
Copy link
Member

jhchen commented Oct 20, 2014

Okay I think I misunderstood originally. You are saying the outer page scrolls up not the editor itself correct?

@sferoze
Copy link
Contributor Author

sferoze commented Oct 20, 2014

Yes it is the outer page. I set the Quill editor height to the scrollHeight so there are no scroll bars in the quill editor itself. So when you paste in the editor, the outer page scrolls to the top.

@jhchen jhchen closed this as completed in 63b3eb3 Oct 20, 2014
@sferoze
Copy link
Contributor Author

sferoze commented Oct 20, 2014

Awesome thanks so much for fixing this! I will update my app as soon as you cut a new release with this commit in it. Thanks again @jhchen

@sferoze
Copy link
Contributor Author

sferoze commented Oct 21, 2014

@jhchen I just tried the new version of quill by compiling the source. I noticed that the main issue is fixed and most of the time it does not scroll or move the page at all. But sometimes when you paste, the page jumps a little. It is tolerable from a user experience standpoint but still a quirk nonetheless.

@jhchen
Copy link
Member

jhchen commented Oct 21, 2014

Yes I agree ideally the page would not move at all. I'll have to see if this behavior is preventable rather than the the current approach of trying to restore position but it's the same issue both within the editor and the page the editor it is on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants