Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the color picker in toolbar show the current selected color? #210

Closed
u9520107 opened this issue Sep 4, 2014 · 7 comments
Closed

Can the color picker in toolbar show the current selected color? #210

u9520107 opened this issue Sep 4, 2014 · 7 comments

Comments

@u9520107
Copy link

u9520107 commented Sep 4, 2014

It seems that the color picker follows the same behavior as font-size picker, where it only glows blue when it's active. It does not seem to be able to show the currently selected color.

Is there an option to enable this behavior or the feature is not yet implemented?

@jhchen
Copy link
Member

jhchen commented Sep 5, 2014

It's not implemented yet.

@leo-zhao
Copy link

leo-zhao commented Sep 7, 2014

Can we integrate 'spectrum color picker' instead of current color picker ?
It will be more advanced, and user can custom font color by using color picker.
color picker : http://bgrins.github.io/spectrum/

@jhchen
Copy link
Member

jhchen commented Sep 9, 2014

@leo-zhao Custom behavior like different color pickers is more suited for a module.

@jhchen jhchen closed this as completed in d14feca Sep 10, 2014
@benbro
Copy link
Contributor

benbro commented Sep 10, 2014

I've tested the latest release with this commit and the color picker still doesn't show the selected color.
This is the expected result:
editor-background
editor-text

@jhchen
Copy link
Member

jhchen commented Sep 10, 2014

I see I thought the OP meant being able to see which color was selected in the dropdown:

screenshot 2014-09-09 21 28 02

I'll reopen with this clarification in mind.

@jhchen jhchen reopened this Sep 10, 2014
@u9520107
Copy link
Author

@jhchen Yes, ideally the toolbar icon itself could show the color as well. But the indicator in the dropdown is helpful too. Thanks for the update!!

@jhchen
Copy link
Member

jhchen commented May 4, 2016

This has been added in the beta release
screenshot 2016-05-04 00 28 50

@jhchen jhchen closed this as completed May 4, 2016
@slab slab deleted a comment from 2008hyt May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants