-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow editor to run without iframe #179
Comments
It's a good idea and I think many users would be interested in this option. We did have this option (with similar implementation) in the early days but a few browser inconsistencies showed up that was difficult to debug. Our test framework is a lot more complete and robust now so though it's probably a good idea to revisit this at some point and add official support. |
+1 started integrating quill into an app and had to go a different route due to the iframe. This is a great looking editor, keep up the good work! |
+1 |
Iframes have been removed in v0.19.0. |
Given that I needed to add modules into quill that had heavy use of javascript libraries and css, I decided to make the editor run outside an iframe. It turned out it is pretty easy to "hack" it doing this:
Basically we mock the iframe with a div.
This works incredibly well so far, the only thing remaining is to be able to modify a little bit the default styles, which is harder to do in this case since they are hidden inside the Renderer module (not exposed like the defaults with Normalizer or Format).
Anyway, I think it would be pretty easy to support a mode that runs without an iframe, for those who need and want to reuse javascript and styles from the top level window.
What do you think?
The text was updated successfully, but these errors were encountered: