Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLOXY-14] Group.getJoinRequests has incorrect typings #278

Closed
guidojw opened this issue May 18, 2021 · 0 comments
Closed

[BLOXY-14] Group.getJoinRequests has incorrect typings #278

guidojw opened this issue May 18, 2021 · 0 comments
Labels
linear Linear integration

Comments

@guidojw
Copy link
Contributor

guidojw commented May 18, 2021 •
edited by skriken
Loading

Group.getJoinRequests has a return type of GroupJoinRequest (only declared and used in that file) with incorrect fields.
The method is basically a proxy to GroupsAPI.getJoinRequests which has a return type of GetJoinRequests.

The difference (and thus the bug) here is that GroupJoinRequest has fields like user, group, ... (which the Roblox API doesn't return) and GetJoinRequest has the correct fields: requester & created.

The implementation of these methods is correct, this is a typing bug only.

BLOXY-14
This was referenced May 19, 2021
Closed
Closed
@skriken skriken added the linear Linear integration label Jun 16, 2023
@skriken skriken changed the title Group.getJoinRequests has incorrect typings [BLOXY-14] Group.getJoinRequests has incorrect typings Jun 16, 2023
@skriken skriken closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linear Linear integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix Group.getJoinRequest typings
2 participants
@skriken @guidojw