Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropzone should support required attribute #387

Closed
endigo9740 opened this issue Oct 16, 2022 · 3 comments · Fixed by #393
Closed

Dropzone should support required attribute #387

endigo9740 opened this issue Oct 16, 2022 · 3 comments · Fixed by #393
Labels
bug Something isn't working

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Oct 16, 2022

Current Behavior

Let's make use of $$restProps to allow for required and any other arbitrary input attributes. The Slide Toggle provides a good reference for how to set this up. Note how we prune $$restProps.class to ensure arbitrary classes are still handled on the parent. We don't want those getting copied to the hidden input as well.

Steps To Reproduce

n/a

Anything else?

Reported by user fnf on Discord in the support channel.

@endigo9740 endigo9740 added the bug Something isn't working label Oct 16, 2022
@endigo9740
Copy link
Contributor Author

Note: let's verify the File Button component follows the same pattern.

@endigo9740
Copy link
Contributor Author

@leranjun I've managed to update this and the File Button components to use $$restProps which means they will pass any valid input attribute directly to the hidden input embedded within the component. I've also update the documentation for both these, the range slider, and slide toggle to indicate the use of $restProps as well.

Thanks for the heads up on this! Expect this update to roll out with the new release coming tomorrow!

@rakuzen25
Copy link
Contributor

Thanks a lot! Looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants