Add sensor_reading and sensor_value helpers #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmerry
added a commit
to ska-sa/katgpucbf
that referenced
this pull request
Apr 5, 2024
Replace them with aiokatcp.Client.sensor_value. This is not yet released; see ska-sa/aiokatcp#86. Closes NGC-1035
8 tasks
aiokatcp and katcp-python support an extension to ?sensor-value that allows a regex to be passed (between slashes) and returns all matching sensors. If such a regex is passed to `sensor_reading`, the return would not contain exactly one sensor value as expected. Add a check that the return contains exactly one inform.
james-smith-za
approved these changes
Apr 8, 2024
Co-authored-by: James Smith <james-smith-za@users.noreply.github.com>
james-smith-za
approved these changes
Apr 8, 2024
| @@ -224,7 +224,7 @@ async def handle_message(self, conn: connection.Connection, msg: core.Message) - | |||
| elif msg.mtype == core.Message.Type.INFORM: | |||
| req.informs.append(msg) | |||
| else: | |||
| self.logger.warning("Unknown message type %s", msg.mtype) # pragma: no cover | |||
There was a problem hiding this comment.
I mean this one looks as though we can probably explicitly test for it but it would be a bit contrived.
There was a problem hiding this comment.
Sure it's possible, but also outside the scope of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These simplify the process of getting the current reading or value of a sensor.