Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wheel from build-system.requires #79

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Remove wheel from build-system.requires #79

merged 1 commit into from
Sep 18, 2023

Conversation

bmerry
Copy link
Contributor

@bmerry bmerry commented Sep 18, 2023

From the setuptools documentation
(https://setuptools.pypa.io/en/latest/userguide/quickstart.html):

Historically this documentation has unnecessarily listed wheel in the
requires list, and many projects still do that. This is not recommended.
The backend automatically adds wheel dependency when it is required, and
listing it explicitly causes it to be unnecessarily required for source
distribution builds. You should only include wheel in requires if you
need to explicitly access it during build time (e.g. if your project
needs a setup.py script that imports wheel).

From the setuptools documentation
(https://setuptools.pypa.io/en/latest/userguide/quickstart.html):

> Historically this documentation has unnecessarily listed wheel in the
> requires list, and many projects still do that. This is not recommended.
> The backend automatically adds wheel dependency when it is required, and
> listing it explicitly causes it to be unnecessarily required for source
> distribution builds. You should only include wheel in requires if you
> need to explicitly access it during build time (e.g. if your project
> needs a setup.py script that imports wheel).
@coveralls
Copy link

coveralls commented Sep 18, 2023

Coverage Status

coverage: 93.416%. remained the same when pulling 9fba36d on remove-wheel into 7454d73 on master.

Copy link
Contributor

@ludwigschwardt ludwigschwardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for giving me some work to do as well :-)

@bmerry bmerry merged commit e52ef57 into master Sep 18, 2023
22 checks passed
@bmerry bmerry deleted the remove-wheel branch September 18, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants