Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mermaid to 8.12 or even 9? #54

Closed
rethab opened this issue Jun 22, 2022 · 7 comments
Closed

Upgrade mermaid to 8.12 or even 9? #54

rethab opened this issue Jun 22, 2022 · 7 comments

Comments

@rethab
Copy link

rethab commented Jun 22, 2022

Hi, in package.json, you're saying mermaid needs to be lower than 8.12. Is there a reason for that?

The reason I'd like to avoid mermaid 8.11.X is that it brings @percy/migrate as a regular dependency, which in turn depends on colors at version 1.4.2.

With 8.12 that dependency was moved to devDependencies: mermaid-js/mermaid#2260

If you need help with this, I'd be happy to assist.

@marikaner
Copy link

@sjwall This would be much appreciated because mermaid has two security vulnerabilities before version 9.1.2.

@BenjaminEHowe
Copy link

This issue seems to be related to #51.

@austince
Copy link

austince commented Aug 3, 2022

As @marikaner mentioned, there's a couple security issues:

  • cross-site scripting vulnerability: GHSA-p3rp-vmj9-gv6v
    • HIGH severity
    • 8.13.8 is the first version to contain a fix
  • CSS injection GHSA-x3vm-38hw-55wf
    • medium severity
    • 9.1.2 is the first version to contain a fix

Perhaps we can target 8.13.8 first? What is necessary for the fix, upgrading the tsc config?

@rethab
Copy link
Author

rethab commented Aug 4, 2022

Until this gets upgraded, or even integrated into docusaurus officially, this is how you can force a new version of mermaid in your package.json:

  "overrides": {
    "mermaid": "^8.12.0"
  },

@sjwall
Copy link
Owner

sjwall commented Aug 4, 2022

This will be fixed by #18 and I am looking into getting this out in the next couple of weeks

The reason for the mermaid version selection is documented here https://sjwall.github.io/mdx-mermaid/docs/mermaid-versions/

@sjwall sjwall closed this as completed Aug 4, 2022
@sjwall
Copy link
Owner

sjwall commented Aug 10, 2022

This is resolved with release v2.0.0-rc1. I'll promote to v2.0.0 in a week or so if there are no bugs reported

@sjwall
Copy link
Owner

sjwall commented Aug 22, 2022

For use with Docusaurus this is resolved in v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants