-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mermaid to 8.12 or even 9? #54
Comments
@sjwall This would be much appreciated because mermaid has two security vulnerabilities before version 9.1.2. |
This issue seems to be related to #51. |
As @marikaner mentioned, there's a couple security issues:
Perhaps we can target 8.13.8 first? What is necessary for the fix, upgrading the |
Until this gets upgraded, or even integrated into docusaurus officially, this is how you can force a new version of mermaid in your package.json: "overrides": {
"mermaid": "^8.12.0"
}, |
This will be fixed by #18 and I am looking into getting this out in the next couple of weeks The reason for the mermaid version selection is documented here https://sjwall.github.io/mdx-mermaid/docs/mermaid-versions/ |
This is resolved with release |
For use with Docusaurus this is resolved in |
Hi, in package.json, you're saying mermaid needs to be lower than 8.12. Is there a reason for that?
The reason I'd like to avoid mermaid 8.11.X is that it brings
@percy/migrate
as a regular dependency, which in turn depends oncolors
at version 1.4.2.With 8.12 that dependency was moved to
devDependencies
: mermaid-js/mermaid#2260If you need help with this, I'd be happy to assist.
The text was updated successfully, but these errors were encountered: