Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validEffortVector() and validEffortArray() should not accept NAs #230

Closed
gustavdelius opened this issue Sep 11, 2021 · 1 comment
Closed

validEffortVector() and validEffortArray() should not accept NAs #230

gustavdelius opened this issue Sep 11, 2021 · 1 comment

Comments

@gustavdelius
Copy link
Member

gustavdelius commented Sep 11, 2021 •
edited
Loading

If an effort vector or array containing an NA is encountered, an error should be triggered, because it is not clear to mizer what it should do with a missing effort.
@gustavdelius gustavdelius changed the title validEffortVector() should not accept NAs validEffortVector() and validEffortArray() should not accept NAs Sep 11, 2021
@gustavdelius
Copy link
Member Author

Actually, NA's should be replaced by the default effort value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gustavdelius