Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in MetricComparisons #108

Closed
alexserra98 opened this issue Jan 19, 2024 · 1 comment · Fixed by #110
Closed

Bug in MetricComparisons #108

alexserra98 opened this issue Jan 19, 2024 · 1 comment · Fixed by #110

Comments

@alexserra98
Copy link
Contributor

alexserra98 commented Jan 19, 2024

Subject of the issue

Hi, I'm rewriting to report a bug when calling return_data_overlap.py in metric_comparison.py

My environment

Steps to reproduce

data1=np.random.rand([1000,100])
data2=np.random.rand([1000,100])
mc = MetricComparisons(data1])
mc.return_data_overlap(data2, k = 20))

Error Message

File "/u/dssc/zenocosini/miniconda3/envs/crfm-helm/lib/python3.10/site-packages/dadapy/metric_comparisons.py", line 545, in return_data_overlap
dist_indices2 = self._get_nn_indices(self.X, None, self.dist_indices)
AttributeError: 'MetricComparisons' object has no attribute 'dist_indices'. Did you mean: 'distances'?

@diegodoimo
Copy link
Collaborator

Thank you, I'll have a look at that.

@diegodoimo diegodoimo linked a pull request Jan 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants