Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit a patch to ES to open MultiSearchResponse and simplify implementation of CoordinateMultiSearchResponse #1

Open
rendel opened this issue Oct 14, 2015 · 0 comments
Assignees

Comments

@rendel
Copy link
Contributor

rendel commented Oct 14, 2015

MultiSearchResponse and MultiSearchResponse#Item have private constructors and variables, making it difficult to extend these two classes. As a work around, we have copy-pasted most of the internal code to replicate their behaviour while being able to extend them. This makes the code more complex and difficult to maintain. The solution would be to propose a patch to the ES community so that MultiSearchResponse becomes extensible by subclassing.

@rendel rendel self-assigned this Oct 14, 2015
@rendel rendel added this to the 1.1 milestone Oct 14, 2015
@rendel rendel removed this from the 2.1.1 milestone Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant