From 455a9492c4d52c161179a6c696105d52124c96b7 Mon Sep 17 00:00:00 2001
From: prateeknima <prateek.nima@siren.io>
Date: Wed, 3 Apr 2024 08:44:29 +0100
Subject: [PATCH] update: Pom files to remove dependency on netty

---
 java/adapter/orc/pom.xml                      |  2 +-
 java/format/pom.xml                           |  2 +-
 java/gandiva/pom.xml                          |  2 +-
 .../module-info-compiler-maven-plugin/pom.xml |  2 +-
 java/maven/pom.xml                            |  2 +-
 java/memory/memory-core/pom.xml               |  2 +-
 java/memory/memory-netty/pom.xml              |  2 +-
 java/memory/memory-unsafe/pom.xml             | 51 ++++++++++++++++++-
 java/memory/pom.xml                           |  2 +-
 java/pom.xml                                  |  4 +-
 java/vector/pom.xml                           | 10 +---
 .../src/main/codegen/includes/vv_imports.ftl  |  1 -
 12 files changed, 61 insertions(+), 21 deletions(-)

diff --git a/java/adapter/orc/pom.xml b/java/adapter/orc/pom.xml
index c34a9f6a85e6f..0540d2ed92337 100644
--- a/java/adapter/orc/pom.xml
+++ b/java/adapter/orc/pom.xml
@@ -111,7 +111,7 @@
     <parent>
         <groupId>org.apache.arrow</groupId>
         <artifactId>arrow-java-root</artifactId>
-        <version>siren-15.0.0-2-SNAPSHOT</version>
+        <version>siren-15.0.0-remove-netty-test-SNAPSHOT</version>
         <relativePath>../../pom.xml</relativePath>
     </parent>
 
diff --git a/java/format/pom.xml b/java/format/pom.xml
index 8c133e400a067..b1d27a65eaf4b 100644
--- a/java/format/pom.xml
+++ b/java/format/pom.xml
@@ -15,7 +15,7 @@
 <parent>
   <artifactId>arrow-java-root</artifactId>
   <groupId>org.apache.arrow</groupId>
-  <version>siren-15.0.0-2-SNAPSHOT</version>
+  <version>siren-15.0.0-remove-netty-test-SNAPSHOT</version>
 </parent>
 
 <artifactId>arrow-format</artifactId>
diff --git a/java/gandiva/pom.xml b/java/gandiva/pom.xml
index 5297c09683460..85f41c7e088fb 100644
--- a/java/gandiva/pom.xml
+++ b/java/gandiva/pom.xml
@@ -14,7 +14,7 @@
     <parent>
       <groupId>org.apache.arrow</groupId>
       <artifactId>arrow-java-root</artifactId>
-      <version>siren-15.0.0-2-SNAPSHOT</version>
+      <version>siren-15.0.0-remove-netty-test-SNAPSHOT</version>
     </parent>
 
     <groupId>org.apache.arrow.gandiva</groupId>
diff --git a/java/maven/module-info-compiler-maven-plugin/pom.xml b/java/maven/module-info-compiler-maven-plugin/pom.xml
index 4be2d7915044e..c61c5d76c549b 100644
--- a/java/maven/module-info-compiler-maven-plugin/pom.xml
+++ b/java/maven/module-info-compiler-maven-plugin/pom.xml
@@ -16,7 +16,7 @@
   <parent>
     <groupId>org.apache.arrow.maven.plugins</groupId>
     <artifactId>arrow-maven-plugins</artifactId>
-    <version>siren-15.0.0-2-SNAPSHOT</version>
+    <version>siren-15.0.0-remove-netty-test-SNAPSHOT</version>
   </parent>
   <artifactId>module-info-compiler-maven-plugin</artifactId>
   <packaging>maven-plugin</packaging>
diff --git a/java/maven/pom.xml b/java/maven/pom.xml
index 8b019aaab0ddd..650b7c27c68ad 100644
--- a/java/maven/pom.xml
+++ b/java/maven/pom.xml
@@ -17,7 +17,7 @@
   -->
   <groupId>org.apache.arrow.maven.plugins</groupId>
   <artifactId>arrow-maven-plugins</artifactId>
-  <version>siren-15.0.0-2-SNAPSHOT</version>
+  <version>siren-15.0.0-remove-netty-test-SNAPSHOT</version>
   <name>Arrow Maven Plugins</name>
   <packaging>pom</packaging>
 
diff --git a/java/memory/memory-core/pom.xml b/java/memory/memory-core/pom.xml
index b330d1c45eefa..fe2e51fb72152 100644
--- a/java/memory/memory-core/pom.xml
+++ b/java/memory/memory-core/pom.xml
@@ -13,7 +13,7 @@
   <parent>
     <artifactId>arrow-memory</artifactId>
     <groupId>org.apache.arrow</groupId>
-    <version>siren-15.0.0-2-SNAPSHOT</version>
+    <version>siren-15.0.0-remove-netty-test-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/java/memory/memory-netty/pom.xml b/java/memory/memory-netty/pom.xml
index 9cc8702744ecb..fa781dd47c098 100644
--- a/java/memory/memory-netty/pom.xml
+++ b/java/memory/memory-netty/pom.xml
@@ -13,7 +13,7 @@
   <parent>
     <artifactId>arrow-memory</artifactId>
     <groupId>org.apache.arrow</groupId>
-    <version>siren-15.0.0-2-SNAPSHOT</version>
+    <version>siren-15.0.0-remove-netty-test-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/java/memory/memory-unsafe/pom.xml b/java/memory/memory-unsafe/pom.xml
index 3ec57c471463a..fb1e9bf47e411 100644
--- a/java/memory/memory-unsafe/pom.xml
+++ b/java/memory/memory-unsafe/pom.xml
@@ -13,7 +13,7 @@
   <parent>
     <artifactId>arrow-memory</artifactId>
     <groupId>org.apache.arrow</groupId>
-    <version>siren-15.0.0-2-SNAPSHOT</version>
+    <version>siren-15.0.0-remove-netty-test-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
@@ -28,5 +28,52 @@
       <artifactId>arrow-memory-core</artifactId>
     </dependency>
   </dependencies>
-
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-shade-plugin</artifactId>
+        <version>3.1.0</version>
+        <executions>
+          <execution>
+            <phase>package</phase>
+            <goals>
+              <goal>shade</goal>
+            </goals>
+            <configuration>
+              <shadedArtifactAttached>false</shadedArtifactAttached>
+              <dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml</dependencyReducedPomLocation>
+              <transformers>
+                <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
+              </transformers>
+              <relocations>
+                <relocation>
+                  <pattern>io.netty</pattern>
+                  <shadedPattern>siren.io.netty</shadedPattern>
+                </relocation>
+              </relocations>
+              <artifactSet>
+                <excludes>
+                  <exclude>org.slf4j</exclude>
+                  <exclude>com.google.code.findbugs</exclude>
+                  <exclude>com.google.guava</exclude>
+                </excludes>
+              </artifactSet>
+              <!--to prevent the Invalid signature file error -->
+              <filters>
+                <filter>
+                  <artifact>*:*</artifact>
+                  <excludes>
+                    <exclude>META-INF/*.SF</exclude>
+                    <exclude>META-INF/*.DSA</exclude>
+                    <exclude>META-INF/*.RSA</exclude>
+                  </excludes>
+                </filter>
+              </filters>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
 </project>
diff --git a/java/memory/pom.xml b/java/memory/pom.xml
index a596fd238513c..b92940b6e5e16 100644
--- a/java/memory/pom.xml
+++ b/java/memory/pom.xml
@@ -14,7 +14,7 @@
   <parent>
     <groupId>org.apache.arrow</groupId>
     <artifactId>arrow-java-root</artifactId>
-    <version>siren-15.0.0-2-SNAPSHOT</version>
+    <version>siren-15.0.0-remove-netty-test-SNAPSHOT</version>
   </parent>
   <artifactId>arrow-memory</artifactId>
   <name>Arrow Memory</name>
diff --git a/java/pom.xml b/java/pom.xml
index b1f331f337a09..991ed60c21995 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -20,7 +20,7 @@
 
   <groupId>org.apache.arrow</groupId>
   <artifactId>arrow-java-root</artifactId>
-  <version>siren-15.0.0-2-SNAPSHOT</version>
+  <version>siren-15.0.0-remove-netty-test-SNAPSHOT</version>
   <packaging>pom</packaging>
 
   <name>Apache Arrow Java Root POM</name>
@@ -33,7 +33,7 @@
     <dep.junit.jupiter.version>5.10.1</dep.junit.jupiter.version>
     <dep.slf4j.version>2.0.9</dep.slf4j.version>
     <dep.guava-bom.version>33.0.0-jre</dep.guava-bom.version>
-    <dep.netty-bom.version>siren-4.1.104-1-SNAPSHOT</dep.netty-bom.version>
+    <dep.netty-bom.version>4.1.104.Final</dep.netty-bom.version>
     <dep.grpc-bom.version>1.60.0</dep.grpc-bom.version>
     <dep.protobuf-bom.version>3.23.1</dep.protobuf-bom.version>
     <dep.jackson-bom.version>2.16.0</dep.jackson-bom.version>
diff --git a/java/vector/pom.xml b/java/vector/pom.xml
index 78f155f44c213..6d633182a712d 100644
--- a/java/vector/pom.xml
+++ b/java/vector/pom.xml
@@ -14,7 +14,7 @@
   <parent>
     <groupId>org.apache.arrow</groupId>
     <artifactId>arrow-java-root</artifactId>
-    <version>siren-15.0.0-2-SNAPSHOT</version>
+    <version>siren-15.0.0-remove-netty-test-SNAPSHOT</version>
   </parent>
   <artifactId>arrow-vector</artifactId>
   <name>Arrow Vectors</name>
@@ -53,16 +53,10 @@
       <artifactId>commons-codec</artifactId>
       <version>1.15</version>
     </dependency>
-    <dependency>
-      <groupId>org.apache.arrow</groupId>
-      <artifactId>arrow-memory-netty</artifactId>
-      <version>${project.version}</version>
-    </dependency>
     <dependency>
       <groupId>org.apache.arrow</groupId>
       <artifactId>arrow-memory-unsafe</artifactId>
       <version>${project.version}</version>
-      <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>com.google.flatbuffers</groupId>
@@ -188,7 +182,7 @@
               <artifactSet>
                 <includes>
                   <include>org.apache.arrow:arrow-memory-core</include>
-                  <include>org.apache.arrow:arrow-memory-netty</include>
+                  <include>org.apache.arrow:arrow-memory-unsafe</include>
                   <include>org.apache.arrow:arrow-format</include>
                   <include>com.google.flatbuffers:*</include>
                 </includes>
diff --git a/java/vector/src/main/codegen/includes/vv_imports.ftl b/java/vector/src/main/codegen/includes/vv_imports.ftl
index cd0e2d7e2a4c4..0bc5d4bba8f76 100644
--- a/java/vector/src/main/codegen/includes/vv_imports.ftl
+++ b/java/vector/src/main/codegen/includes/vv_imports.ftl
@@ -20,7 +20,6 @@ import static org.apache.arrow.util.Preconditions.checkState;
 
 import com.google.flatbuffers.FlatBufferBuilder;
 
-import siren.io.netty.buffer.*;
 
 import org.apache.arrow.memory.*;
 import org.apache.arrow.util.Preconditions;