Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document legacyRoutes flag and make it disabled by default #224

Closed
fatso83 opened this issue May 15, 2024 · 2 comments
Closed

Document legacyRoutes flag and make it disabled by default #224

fatso83 opened this issue May 15, 2024 · 2 comments

Comments

@fatso83
Copy link
Contributor

fatso83 commented May 15, 2024

PR #223 introduced the legacyRoutes flag and set it to be enabled by default to ensure the previous behavior was kept. To enable the new features in the underlying lib, we should consider enabling it by default, but this requires updating docs in Nise first in any case.

@fatso83 fatso83 changed the title Document legacyRoutes flag and make it disabled by defaulg Document legacyRoutes flag and make it disabled by default Sep 13, 2024
@fatso83
Copy link
Contributor Author

fatso83 commented Sep 13, 2024

@43081j Does this option make any sense anymore, now that the underlying library has changed its syntax yet again, so that ? no longer has special meaning? I think not, so I'd roll the change/feature back to how it was, before the next major.

Ref #226 and #223

@43081j
Copy link
Contributor

43081j commented Sep 13, 2024

Ah interesting! They made another breaking change I see 😅

You're probably right and we can drop this option since ? has no special meaning anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants