Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git push does not automatically trigger a re-build #142

Closed
tdelhomme opened this issue Aug 8, 2018 · 5 comments
Closed

Git push does not automatically trigger a re-build #142

tdelhomme opened this issue Aug 8, 2018 · 5 comments

Comments

@tdelhomme
Copy link

tdelhomme commented Aug 8, 2018

Link to Container Collection Log, Build, or Collection (in that order)

https://www.singularity-hub.org/collections/1404

Behavior when Building Locally

No issue with building.

Error on Singularity Hub

No errors.

What do you think is going on?

Build trigger is on commits.
Here is my github repo, I use conda to install softwares, from both a YAML file describing them and a singularity file where commands to use conda are stored.
The problem here is that my container depends on these two files but the build is done only if the modification is done on the singularity file.
I suggest that we should have a re-build for each commit (not depending on the modified file), what do you think about this?

@vsoch
Copy link
Member

vsoch commented Aug 8, 2018

I would recommend for your case either a manual build, or a deployment build. Since Singularity Hub is maintained by just me, with limited resources, I can't afford to have the container build with every user commit. There are definitely options for you to take (via deployment, or manual, or some other method that changes the file) so I hope these might work for you :)

@vsoch
Copy link
Member

vsoch commented Oct 9, 2018

See my comments at the issue linked above. There are several strategies you could take to get the behavior you want, and we do need to keep the way Singularity Hub is now as a strategy to choose the "latest" Singularity file when there are more than one. It's also (typically) redundant to rebuild on an unchanged file, so if this doesn't work for you, I'd suggest a manual build or a CI strategy that DOES edit the file (for example, why not have a version string as a variable (environment or label) in the build recipe?

@vsoch vsoch closed this as completed Oct 9, 2018
@tdelhomme
Copy link
Author

@vsoch this is a great idea to add a version on the singularity file to force the build, thanks! Will try that.

@vsoch
Copy link
Member

vsoch commented Oct 9, 2018

Awesome! Yeah I needed the same trick a while back, and funnily enough it made my containers a little better :) Happy building!

@tdelhomme
Copy link
Author

Thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants