New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse the string instead of the current regex mess #13

Closed

sindresorhus opened this issue Jun 19, 2016 · 0 comments

Labels

enhancement help wanted

Owner

sindresorhus commented Jun 19, 2016

Regexes doesn't scale for this. Would be much easier to just iterate through the string and keep some state.

Something like: https://github.com/sindresorhus/strip-css-comments/blob/master/index.js

Should be something that can be shared with https://github.com/sindresorhus/to-double-quotes

sindresorhus added enhancement help wanted labels

sindresorhus mentioned this issue

Fix backslash bug #12

Closed

ruipneves mentioned this issue

Use string processing instead of regex #14

Merged

1 task

sindresorhus closed this as completed in #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment