Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory Expansion 8.X on Windows #70

Closed
calebboyd opened this issue Feb 13, 2018 · 4 comments
Closed

Directory Expansion 8.X on Windows #70

calebboyd opened this issue Feb 13, 2018 · 4 comments

Comments

@calebboyd
Copy link

calebboyd commented Feb 13, 2018 •
edited
Loading

I see this passed in CI so it must just be a windows issue only

Running at 5d3d4de

image

(expansion is working fine in latest 7.X (pending #63))
@calebboyd calebboyd changed the title Directory Expansion on Windows (8.0) Directory Expansion 8.X on Windows Feb 13, 2018
@mrmlnc
Copy link
Contributor

mrmlnc commented Feb 13, 2018

This is due to a stupid mistake in the fast-glob package. I forgot about converting the \ symbol to UNIX style (/) in the patterns.

So, will be fixed today. Sorry for this situation.

@mrmlnc mrmlnc mentioned this issue Feb 13, 2018
Merged
@mrmlnc
Copy link
Contributor

mrmlnc commented Feb 13, 2018

@sindresorhus, may be you want set-up AppVeyor for globby?

@calebboyd calebboyd mentioned this issue Feb 13, 2018
Closed
@sindresorhus
Copy link
Owner

I don't really want 😝, as AppVeyor is annoying to setup and use, and it's flaky, but yes, I'll do it.

@mrmlnc
Copy link
Contributor

mrmlnc commented Feb 13, 2018 •
edited
Loading

Fixed by fast-glob@2.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sindresorhus @calebboyd @mrmlnc