From ac89639d2072eb3eda28cf5ca45e0c48ad6eb70c Mon Sep 17 00:00:00 2001 From: Grigory Date: Sun, 16 Jun 2024 18:50:33 +0500 Subject: [PATCH 1/3] prefer-node-protocol: ignore bun modules --- rules/prefer-node-protocol.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/prefer-node-protocol.js b/rules/prefer-node-protocol.js index 6515a1a600..f730c0a6b5 100644 --- a/rules/prefer-node-protocol.js +++ b/rules/prefer-node-protocol.js @@ -32,8 +32,8 @@ const create = () => ({ if ( typeof value !== 'string' || value.startsWith('node:') + || value.match(/^bun(:\w+|$)/) || !isBuiltinModule(value) - || !isBuiltinModule(`node:${value}`) ) { return; } From a2c81f0ff188b1ee4766d844bfce7d36ce5e5420 Mon Sep 17 00:00:00 2001 From: Grigory Date: Tue, 18 Jun 2024 22:24:40 +0500 Subject: [PATCH 2/3] use RegExp.test --- rules/prefer-node-protocol.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/prefer-node-protocol.js b/rules/prefer-node-protocol.js index f730c0a6b5..9b8a98722b 100644 --- a/rules/prefer-node-protocol.js +++ b/rules/prefer-node-protocol.js @@ -32,7 +32,7 @@ const create = () => ({ if ( typeof value !== 'string' || value.startsWith('node:') - || value.match(/^bun(:\w+|$)/) + || /^bun(:\w+|$)/.test(value) || !isBuiltinModule(value) ) { return; From c45f57497d778aaa6d2cd183a25c9b0f33b81084 Mon Sep 17 00:00:00 2001 From: Grigory Date: Fri, 21 Jun 2024 20:04:07 +0500 Subject: [PATCH 3/3] Update rules/prefer-node-protocol.js Co-authored-by: fisker Cheung --- rules/prefer-node-protocol.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/prefer-node-protocol.js b/rules/prefer-node-protocol.js index 9b8a98722b..398d5684af 100644 --- a/rules/prefer-node-protocol.js +++ b/rules/prefer-node-protocol.js @@ -32,7 +32,7 @@ const create = () => ({ if ( typeof value !== 'string' || value.startsWith('node:') - || /^bun(:\w+|$)/.test(value) + || /^bun(?::|$)/.test(value) || !isBuiltinModule(value) ) { return;