Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check .hasAttribute() in prefer-dom-node-dataset rule #1669

Closed
fisker opened this issue Dec 29, 2021 · 1 comment · Fixed by #1673
Closed

Check .hasAttribute() in prefer-dom-node-dataset rule #1669

fisker opened this issue Dec 29, 2021 · 1 comment · Fixed by #1673
Labels
enhancement help wanted

Comments

@fisker
Copy link
Collaborator

fisker commented Dec 29, 2021 •
edited
Loading

MDN suggest using in operator to check existence, I'm not sure what's the best, maybe hasOwnProperty()?

Fail

element.hasAttribute('data-foo');

Pass

"foo" in element.dataset;
@sindresorhus
Copy link
Owner

Yes, it should recommend .hasOwnProperty(). We can add a code TODO comment to switch to Object.hasOwn later on.

@fisker fisker mentioned this issue Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prefer-dom-node-dataset: Check .hasAttribute() and .getAttribute() fisker/eslint-plugin-unicorn
2 participants
@sindresorhus @fisker