string-content: Fix JSX autofix for newlines, etc. (#2222)

sindresorhus · Nov 27, 2023 · b95e75e · b95e75e
1 parent f475168
commit b95e75e
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 4 deletions.
diff --git a/rules/string-content.js b/rules/string-content.js
@@ -105,10 +105,13 @@ const create = context => {
 
 		const fixed = string.replace(regex, suggest);
 		const fix = type === 'Literal'
-			? fixer => fixer.replaceText(
-				node,
-				escapeString(fixed, raw[0]),
-			)
+			? fixer => {
+				const [quote] = raw;
+				return fixer.replaceText(
+					node,
+					node.parent.type === 'JSXAttribute' ? quote + fixed + quote : escapeString(fixed, quote),
+				);
+			}
 			: fixer => replaceTemplateElement(
 				fixer,
 				node,

diff --git a/test/string-content.mjs b/test/string-content.mjs
@@ -45,6 +45,13 @@ const createSuggestionError = (match, suggest, output) => [
 ];
 
 test({
+	testerOptions: {
+		parserOptions: {
+			ecmaFeatures: {
+				jsx: true,
+			},
+		},
+	},
 	valid: [
 		'const foo = "";',
 		...[
@@ -279,5 +286,19 @@ test({
 			errors: createError('no', 'yes'),
 		},
 		/* eslint-enable no-template-curly-in-string */
+		{
+			code: outdent`
+				const foo = <div className='
+					no
+				' />
+			`,
+			output: outdent`
+				const foo = <div className='
+					yes
+				' />
+			`,
+			options: [{patterns: noToYesPattern}],
+			errors: createError('no', 'yes'),
+		},
 	],
 });