From 461b01cd69c42396ee1bda7ad583c4e2739b5696 Mon Sep 17 00:00:00 2001 From: Federico Brigante Date: Mon, 9 Sep 2024 00:33:38 +0630 Subject: [PATCH] Remove `better-regex` from recommended rules (#2443) Co-authored-by: fisker --- docs/rules/better-regex.md | 2 +- readme.md | 2 +- rules/better-regex.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/rules/better-regex.md b/docs/rules/better-regex.md index c2baeb27fa..dd1b44d126 100644 --- a/docs/rules/better-regex.md +++ b/docs/rules/better-regex.md @@ -1,6 +1,6 @@ # Improve regexes by making them shorter, consistent, and safer -💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/sindresorhus/eslint-plugin-unicorn#preset-configs-eslintconfigjs). +🚫 This rule is _disabled_ in the ✅ `recommended` [config](https://github.com/sindresorhus/eslint-plugin-unicorn#preset-configs-eslintconfigjs). 🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix). diff --git a/readme.md b/readme.md index 33619961eb..4d1e5864bc 100644 --- a/readme.md +++ b/readme.md @@ -110,7 +110,7 @@ If you don't use the preset, ensure you use the same `env` and `parserOptions` c | Name                                    | Description | 💼 | 🔧 | 💡 | | :----------------------------------------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :- | :- | :- | -| [better-regex](docs/rules/better-regex.md) | Improve regexes by making them shorter, consistent, and safer. | ✅ | 🔧 | | +| [better-regex](docs/rules/better-regex.md) | Improve regexes by making them shorter, consistent, and safer. | | 🔧 | | | [catch-error-name](docs/rules/catch-error-name.md) | Enforce a specific parameter name in catch clauses. | ✅ | 🔧 | | | [consistent-destructuring](docs/rules/consistent-destructuring.md) | Use destructured variables over properties. | | 🔧 | 💡 | | [consistent-empty-array-spread](docs/rules/consistent-empty-array-spread.md) | Prefer consistent types when spreading a ternary in an array literal. | ✅ | 🔧 | | diff --git a/rules/better-regex.js b/rules/better-regex.js index 96329bbec8..6eb83a8902 100644 --- a/rules/better-regex.js +++ b/rules/better-regex.js @@ -136,7 +136,7 @@ module.exports = { type: 'suggestion', docs: { description: 'Improve regexes by making them shorter, consistent, and safer.', - recommended: true, + recommended: false, }, fixable: 'code', schema,