Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symbol as eventName #16

Closed
sindresorhus opened this issue Dec 3, 2017 · 7 comments · Fixed by #43
Closed

Support Symbol as eventName #16

sindresorhus opened this issue Dec 3, 2017 · 7 comments · Fixed by #43
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Dec 3, 2017

Issuehunt badges

See #12 (comment) for use-case.

I think #13 should be implemented first though, so we can make sure it's not hard to define in a TS type definition.


Note: This issue has a bounty, so it's expected that you are an experienced programmer and that you give it your best effort if you intend to tackle this. Don't forget, if applicable, to add tests, docs (double-check for typos), and update TypeScript definitions. And don't be sloppy. Review your own diff multiple times and try to find ways to improve and simplify your code. Instead of asking too many questions, present solutions. The point of an issue bounty is to reduce my workload, not give me more. Include a 🦄 in your PR description to indicate that you've read this. Thanks for helping out 🙌 - @sindresorhus


IssueHunt Summary

stroncium stroncium has been rewarded.

Backers (Total: $60.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@novemberborn
Copy link
Collaborator

We'll be able to support this in the Emittery class itself, but TypeScript cannot yet express symbol types sufficiently for use in the Emittery.Typed class. That's OK though, we can definitely tackle this now.

@sindresorhus
Copy link
Owner Author

@dinoboff
Copy link
Contributor

dinoboff commented Feb 4, 2018

AFAIK, the support is still limited: they cannot be use with keyOf or as index signature parameter. It can be used in overloaded method signatures however.

@sindresorhus
Copy link
Owner Author

The above issues has been fixed.

@issuehunt-oss
Copy link

issuehunt-oss bot commented Sep 19, 2019

@issuehunt has funded $60.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Sep 19, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Feb 25, 2020

@sindresorhus has rewarded $54.00 to @stroncium. See it on IssueHunt

  • 💰 Total deposit: $60.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $6.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants