Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property defination are different between index.d.ts and index.js #156

Closed
jrainlau opened this issue Oct 24, 2022 · 0 comments · Fixed by #157
Closed

Property defination are different between index.d.ts and index.js #156

jrainlau opened this issue Oct 24, 2022 · 0 comments · Fixed by #157

Comments

@jrainlau
Copy link
Contributor

jrainlau commented Oct 24, 2022 •
edited
Loading

Inside the index.d.ts, one property of interface File is filename:

image

While inside the index.js, there are fileName, which would occur errors in typescript.

image

I've make a PR to fix this:
157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix property defination are different between index.d.ts and index.js jrainlau/electron-dl
1 participant
@jrainlau