Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-platform build support #5

Closed
danielsaidi opened this issue Dec 21, 2023 · 1 comment
Closed

Multi-platform build support #5

danielsaidi opened this issue Dec 21, 2023 · 1 comment

Comments

@danielsaidi
Copy link

Perhaps I'm approaching this incorrectly, but I'm having problems previewing SwiftUI for iOS while this package is added to the project.

I have disabled LaunchAtLogin and MenuBarExtraAccess for iOS like this:

image

This makes it possible to build the project for iOS, but I still get a crash when previewing.

image

Any ideas on how to make previews work would be amazing. Otherwise, and it probably makes little sense for you to do it since this is explicitly a macOS package, adding #if os(macOS) around the code in this package and MenuBarExtraAccess, would make the package build on iOS.

Thank you

@danielsaidi
Copy link
Author

Thank you! Together with KeyboardShortcuts 1.16.1, I can confirm that all build errors are now gone.

Too bad that SwiftUI previews don't take platform exclusion into consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant