-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YogaSMC implementation #71
Comments
I second this, YogaSMC looks great, especially the fan control abilities. @xuandung38 my understanding is that this replaced VirtualSMC is this correct? |
No! YogaSMC based on VirtualSMC. So we allway need VirtualSMC and load it before YogaSMC. |
I tried YogaSMC, it works very well. But I don't know how to fix sleep so I'm still temporarily using this repo. If you need it I will send it to you. |
Hi, I did some researches but unfortunately I don't have the knowledge and time to implement this right now. |
maybe @xuandung38 can point you in the right direction as what needs to be done? from what @xuandung38 is saying its a KEXT and System preferences pane that runs alongside VirtualSMC and can be used instead of ThinkAssistant so in essence its about adding the KEXT Into the EFI built with a supplementary step of adding the preference pane afterwards. |
@simprecicchiani thank you! Here is my EFI OC 0.6.3 with yogaSMC. You can take it and researches |
There’s no need for supplementary SSDTs? |
No, we need to add some additional SSDT to manage Battery (Battery threshold), Fan and LED control. |
Here is guide: Remove all _QXX method in ACPI->patch Add YogaSMC.kext to kext and kernel -> done |
Have you already done that? Does it fix sleep issues? |
Yeah! When i repatch your ACPI it work well. But led control not work , i'm researching. |
try it and tell me. |
I made some changes to the original ACPI patches from OC-Little, then I looked into @tylernguyen x1c6 config to see how he implemented the tool. Edit: I also added BrightnessKeys.kext |
Let's me test it! |
Everything is fine except the charge threshold |
Any update ? |
Progress on this is looking good, noticed new version available with a ton of improvements: https://github.com/zhen-zen/YogaSMC/releases/tag/1.4.0 |
Led control and Mic button broke with this release |
Hi @simprecicchiani ! I have been using your efi so far I have not seen any inconvenience or bugs, I think it's time to release a separate branch for this version. |
Does this version fix it? |
Yes it does, everything works as expected.
I was thinking of releasing it with the next OpenCore update. I was quite happy with ThinkpadAssistant but, from what I understood, it will be soon deprecated. I don't think there is a need for two separate configs. |
OpenCore 0.6.5 released. let's do it <3 |
#82. Let's keep general comments outside of issues' section. I'm closing this for now as YogaSMC seems fully working to me. |
I find YogaSMC to have more superior features than ThinkpadAssistant. For example the Fan control, Charge Threshold Management ... really useful. Would you mind spending some of your precious time trying to research it?
The text was updated successfully, but these errors were encountered: