Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YogaSMC implementation #71

Closed
xuandung38 opened this issue Dec 8, 2020 · 24 comments
Closed

YogaSMC implementation #71

xuandung38 opened this issue Dec 8, 2020 · 24 comments

Comments

@xuandung38
Copy link

I find YogaSMC to have more superior features than ThinkpadAssistant. For example the Fan control, Charge Threshold Management ... really useful. Would you mind spending some of your precious time trying to research it?

@aptonline
Copy link

I second this, YogaSMC looks great, especially the fan control abilities. @xuandung38 my understanding is that this replaced VirtualSMC is this correct?

@xuandung38
Copy link
Author

No! YogaSMC based on VirtualSMC. So we allway need VirtualSMC and load it before YogaSMC.

@xuandung38
Copy link
Author

I tried YogaSMC, it works very well. But I don't know how to fix sleep so I'm still temporarily using this repo. If you need it I will send it to you.

@simprecicchiani
Copy link
Owner

Hi, I did some researches but unfortunately I don't have the knowledge and time to implement this right now.

@aptonline
Copy link

maybe @xuandung38 can point you in the right direction as what needs to be done? from what @xuandung38 is saying its a KEXT and System preferences pane that runs alongside VirtualSMC and can be used instead of ThinkAssistant so in essence its about adding the KEXT Into the EFI built with a supplementary step of adding the preference pane afterwards.

@xuandung38
Copy link
Author

xuandung38 commented Dec 10, 2020

@simprecicchiani thank you!

Here is my EFI OC 0.6.3 with yogaSMC.
I just don't know how to fix sleep for it.

You can take it and researches

T460SxYogaSMC.zip

@simprecicchiani
Copy link
Owner

There’s no need for supplementary SSDTs?

@xuandung38
Copy link
Author

xuandung38 commented Dec 11, 2020

No, we need to add some additional SSDT to manage Battery (Battery threshold), Fan and LED control.

@xuandung38
Copy link
Author

Here is guide:
Change ERAM in method RE1B to ERM2 or any.
Add 2 method to SSDT_BAT0 like this
image
Download Latest release
Compile and add SSD-DYTC-Tx80.dsl + SSD-THINK.dsl to ACPI

Remove all _QXX method in ACPI->patch

Add YogaSMC.kext to kext and kernel -> done

@simprecicchiani
Copy link
Owner

Have you already done that? Does it fix sleep issues?

@xuandung38
Copy link
Author

xuandung38 commented Dec 13, 2020

Yeah! When i repatch your ACPI it work well. But led control not work , i'm researching.

Screen Shot 2020-12-13 at 16 31 37

Screen Shot 2020-12-13 at 16 30 09
EFI.zip

@xuandung38
Copy link
Author

try it and tell me.

@simprecicchiani
Copy link
Owner

simprecicchiani commented Dec 18, 2020

I made some changes to the original ACPI patches from OC-Little, then I looked into @tylernguyen x1c6 config to see how he implemented the tool.
I'm still not confident with ACPI but it seems that most of YogaSMC's functions are working.
Some LEDs are fully functional, others are partially supported (i.e. charging light can't pulse, only blink).
EFI.zip

Edit: I also added BrightnessKeys.kext

@xuandung38
Copy link
Author

I made some changes to the original ACPI patches from OC-Little, then I looked into @tylernguyen x1c6 config to see how he implemented the tool.
I'm still not confident with ACPI but it seems that most of YogaSMC's functions are working.
Some LEDs are fully functional, others are partially supported (i.e. charging light can't pulse, only blink).
EFI.zip

Edit: I also added BrightnessKeys.kext

Let's me test it!

@simprecicchiani simprecicchiani changed the title [help wanted] Opencore 0.6.4 with YogaSMC YogaSMC implementation Dec 19, 2020
@xuandung38
Copy link
Author

xuandung38 commented Dec 21, 2020

Everything is fine except the charge threshold

@xuandung38
Copy link
Author

Any update ?

@aptonline
Copy link

Progress on this is looking good, noticed new version available with a ton of improvements: https://github.com/zhen-zen/YogaSMC/releases/tag/1.4.0

@simprecicchiani
Copy link
Owner

Progress on this is looking good, noticed new version available with a ton of improvements: https://github.com/zhen-zen/YogaSMC/releases/tag/1.4.0

Led control and Mic button broke with this release

@xuandung38
Copy link
Author

Hi @simprecicchiani ! I have been using your efi so far I have not seen any inconvenience or bugs, I think it's time to release a separate branch for this version.

@aptonline
Copy link

Led control and Mic button broke with this release

Does this version fix it?

https://github.com/zhen-zen/YogaSMC/releases/tag/1.4.1

@simprecicchiani
Copy link
Owner

Does this version fix it?

https://github.com/zhen-zen/YogaSMC/releases/tag/1.4.1

Yes it does, everything works as expected.

Hi @simprecicchiani ! I have been using your efi so far I have not seen any inconvenience or bugs, I think it's time to release a separate branch for this version.

I was thinking of releasing it with the next OpenCore update. I was quite happy with ThinkpadAssistant but, from what I understood, it will be soon deprecated. I don't think there is a need for two separate configs.

@xuandung38
Copy link
Author

OpenCore 0.6.5 released. let's do it <3

@simprecicchiani
Copy link
Owner

simprecicchiani commented Jan 5, 2021

OpenCore 0.6.5 released. let's do it <3

#82. Let's keep general comments outside of issues' section.

I'm closing this for now as YogaSMC seems fully working to me.

@mhl221135
Copy link
Contributor

mhl221135 commented Jan 8, 2021

This thing not working its jumping to balanced and not changing, and what it is performance modes ?)Screenshot_20210108-182402_GitHub.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants