Add isRequired and isNotRequired assertions #65
Conversation
scalvert
changed the title
lib/assertions/is-not-required.js
Outdated
| if (!element) return; | ||
|
|
||
| let result = element.required === false; | ||
| let actual = element.required === true ? 'required' : 'not required'; |
There was a problem hiding this comment.
I think you can just reuse the result variable here instead of comparing the property again
There was a problem hiding this comment.
Done. Also updated is-required.js to do the same. FWIW, this is what is-checked does, so we may want to update that too separately.
There was a problem hiding this comment.
yeah, agreed. I merged it and planned to do a small cleanup round later :)
scalvert
changed the title
lib/assertions/is-not-required.js
Outdated
| let element = this.findTargetElement(); | ||
| if (!element) return; | ||
|
|
||
| let result = element.required === false; |
There was a problem hiding this comment.
what happens if the element is not an <input> element? would required be undefined then and fail this check?
There was a problem hiding this comment.
Good catch. I've added a conditional, which will throw if an element is passed that is not one of HTMLInputElement, HTMLTextAreaElement, or HTMLSelectElement.
|
@Turbo87 anything else I need to do to push this in? |
remind me about it 😜 |
Implements #56
Fills in the API for
isRequiredisNotRequiredTODO:
isRequiredisNotRequired