TypeScript: Turn on noImplicityAny and fix a few type signatures
#587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasHill
commented
Dec 27, 2019
|
@Turbo87 is there any appetite for this change? |
|
generally, yes. but I haven't had time yet to review it properly 😞 |
|
Ok thanks! |
scalvert
requested changes
Jan 13, 2020
There was a problem hiding this comment.
These changes look largely good to me. I'm sure you feel the same way, but it's mildly annoying to have to @ts-ignore all those lines to explicitly opt out of type checking for those tests that are explicitly checking invalid parameter types. I don't have another solution for this, so we'll have to live with it.
|
@LucasHill thanks for doing this! |
LucasHill
commented
Jan 18, 2020
LucasHill
force-pushed
the
use-no-implicit-any
branch
from
8475eac to
8f171bd
Compare
|
@scalvert updated! thanks for the feedback |
scalvert
reviewed
Jan 21, 2020
scalvert
reviewed
Jan 21, 2020
scalvert
reviewed
Jan 21, 2020
scalvert
requested changes
Jan 21, 2020
Turbo87
approved these changes
Feb 2, 2020
Turbo87
changed the title
noImplicityAny and fix a few type signatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was debugging some type issues I was having and decided to turn on 'noImplicityAny' (considered a best practice in TS). This should tighten up the types to be a lot more useful. I tried to make minimal actual code changes and just do types in this pass.