Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In some tests was thrown undefined. #2344

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

candunaj
Copy link
Contributor

@candunaj candunaj commented Nov 29, 2021

In 4 tests was thrown undefined in async call. Test finished on that line without executing expect statement but it did not fail. It was expected that it would throw undefined.

await session.restore();
expect(session.get('isAuthenticated')).to.be.false;

I have fixed it by moving expect statement into a catch block.

try {
          await session.restore();
} catch (_error) {
          expect(session.get('isAuthenticated')).to.be.false;
}

@marcoow marcoow merged commit 1d70e82 into master Nov 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the throw-undefined-bug-in-tests branch November 30, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants