Allow CI for ember-beta to fail #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
reviewed
Oct 29, 2021
.github/workflows/ci.yml
Outdated
| - workspace: classic-test-app | ||
| test-suite: "test:one ember-release" | ||
| allow-failure: false | ||
| allow-failure: true |
There was a problem hiding this comment.
I guess ember-release should still not be allowed to fail?
There was a problem hiding this comment.
Yes, you are right. I am going to fix it.
marcoow
requested changes
Oct 29, 2021
candunaj
force-pushed
the
allow-unsupported-CI-fail
branch
from
ade9bc6
to
6dda37c
Compare
candunaj
force-pushed
the
allow-unsupported-CI-fail
branch
from
6dda37c
to
c4dd7ef
Compare
candunaj
changed the title
marcoow
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow CI for ember-beta to fail because the current version of ember-simple-auth does not support ember 4.