Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #2294

Merged
merged 6 commits into from
May 7, 2021
Merged

Fix tests #2294

merged 6 commits into from
May 7, 2021

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Apr 27, 2021

This fixes CI by:

@marcoow marcoow force-pushed the ember-init branch 3 times, most recently from b586788 to 6ecdfe8 Compare April 27, 2021 16:11
@marcoow marcoow force-pushed the ember-init branch 4 times, most recently from bec2878 to 933b996 Compare May 5, 2021 09:35
@marcoow marcoow force-pushed the ember-init branch 6 times, most recently from 6db3ee2 to 91241fe Compare May 5, 2021 10:09
@marcoow marcoow requested a review from a team May 5, 2021 11:43
@marcoow marcoow marked this pull request as ready for review May 5, 2021 11:43

module.exports = {
framework: 'mocha',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not needed anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what ember init generates but it seems fine since the testem docs say:

framework - the test framework that you are using, in the browser, in the case that you are not also using the test_page option.

@marcoow marcoow merged commit 63a07e3 into master May 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the ember-init branch May 7, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants