Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize docs #2136

Merged
merged 9 commits into from
Mar 30, 2020
Merged

Modernize docs #2136

merged 9 commits into from
Mar 30, 2020

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Mar 18, 2020 •
edited
Loading

This modernizes the documentation by using Octane patterns like

  • native classes
  • decorators
  • modifiers

It also adds missing imports to the code examples so they can be copy/pasted. The 2 guides on using ESA with Torii to implement authentication with GitHub are merged into one.

TODO

  • there are now 2 guides for Torii/GitHub auth that both use Octane syntax and should be unified into 1

@marcoow marcoow force-pushed the modernize-docs branch 2 times, most recently from da2daf3 to 645fa95 Compare March 18, 2020 14:39
@marcoow marcoow requested a review from sdebarros March 18, 2020 14:40
@marcoow marcoow marked this pull request as ready for review March 18, 2020 14:41
@marcoow marcoow changed the title Modernize docs [WIP] Modernize docs Mar 18, 2020
@marcoow marcoow removed the request for review from sdebarros March 19, 2020 08:30
@marcoow marcoow requested a review from sdebarros March 19, 2020 11:54
@marcoow marcoow changed the title [WIP] Modernize docs Modernize docs Mar 19, 2020
sdebarros
sdebarros reviewed Mar 27, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
sdebarros
sdebarros reviewed Mar 27, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
marcoow and others added 5 commits March 27, 2020 21:11
@marcoow
Update README.md
4d4292a 
Co-Authored-By: Samanta de Barros <samanta.debarros@simplabs.com>
@marcoow
Apply suggestions from code review
17f7bcb 
Co-Authored-By: Samanta de Barros <samanta.debarros@simplabs.com>
@marcoow
add missing service injection
4bb621f
@marcoow
fix env var name
21cda24
@marcoow
remove old guide
efa1f74
@marcoow marcoow requested a review from sdebarros March 27, 2020 20:15
@marcoow marcoow merged commit 1b3ba68 into master Mar 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the modernize-docs branch March 30, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdebarros sdebarros sdebarros approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoow @sdebarros