Do not include pupmod::agent::cron if daemonize=true

[nick-markowski]

Including pupmod::agent::cron when daemonize = true causes a conflict of puppet service management. Recommend updating the logic in init.pp to exclude pupmod::agent::cron and ensure the legacy cron and new systemd timer absent, when daemonize = true:

if $daemonize {
  $_puppet_service_ensure = 'running'
  cron { 'puppetagent': ensure => 'absent' }
  systemd::timer { 'puppet_agent.timer': ensure => 'absent' }
}
else {
  $_puppet_service_ensure = 'stopped'
  include 'pupmod::agent:cron'
}

[trevor-vaughan]

The puppet::agent::cron::enable boolean should also disable the exec that kills the puppet service if set to false.

[greatflyingsteve]

I hate to add insult to injury, but how is such a glaringly obvious bug, that kneecaps the majority use case for the Puppet Agent, that even the meanest testing should have uncovered, still present four releases and over two years later?

We were using simp-pupmod in our environment, and this bug just bit us. As an additional heads-up, there's one more problem to solve: when Puppet is applying the change from vendor service to timer unit (or vice versa), the order of operations is non-deterministic, and the agent will accidentally suicide about half of the time when it removes or nerfs the service unit it was running under and systemd immediately kills it before it can start the new run method.

When this gets fixed, please test the transition from vendor service to timer unit and vice versa.