Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ng-dev] Make sure AngularContext.current is always cleaned up #98

Closed
ersimont opened this issue Jan 14, 2023 · 1 comment
Closed

[ng-dev] Make sure AngularContext.current is always cleaned up #98

ersimont opened this issue Jan 14, 2023 · 1 comment

Comments

@ersimont
Copy link
Member

If a context throws an error during cleanup, it can leave .current defined and cause all remaining tests to fail.
@ersimont
Copy link
Member Author

An old TODO in ComponentContext.constructor:

    // TODO: once cleanup of contexts is not so touchy, move this below super() and use shortcut `private` declarations on constructor params

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ersimont