Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream dependency has a vulnerability (minimist 0.0.8 from mkdirp 0.5.1) #123

Closed
DarthHater opened this issue Mar 27, 2020 · 4 comments · Fixed by #126
Closed

Upstream dependency has a vulnerability (minimist 0.0.8 from mkdirp 0.5.1) #123

DarthHater opened this issue Mar 27, 2020 · 4 comments · Fixed by #126

Comments

@DarthHater
Copy link
Contributor

Hi there!

I work on a tool called auditjs, and in one of our scans of our tool, we discovered that:

(base) 527 auditjs (DependencyBumps)$ npm ls minimist --production
auditjs@4.0.13 /Users/jeffryhesse/code/sonatype/auditjs
└─┬ node-persist@3.0.5
  └─┬ mkdirp@0.5.1
    └── minimist@0.0.8 

CVE for minimist is here:

https://nvd.nist.gov/vuln/detail/CVE-2020-7598

You'll want to examine the actual risk to your application, but my suggestion would be to just remove the mkdirp dependency:

The suggestion from me (and I'd gladly send you the PR to do so) is to remove the mkdirp and use fs.mkDirSync in node 10.12 forward. Node 8 is sunset at this point.

You can do: fs.mkdirSync(targetDir, { recursive: true }); to accomplish what mkdir -p does.

Let me know if you'd like a PR, glad to help out!

We use node-persist by the way and I love it. Thanks a ton for creating this!

@akhoury
Copy link
Collaborator

akhoury commented May 30, 2020

sure @DarthHater PR is welcomed, sorry for the late reply, been crazy busy lately

@DarthHater
Copy link
Contributor Author

@akhoury PR sent!

@akhoury
Copy link
Collaborator

akhoury commented Jun 4, 2020

thanks! node-persist@3.1.0 published

@DarthHater
Copy link
Contributor Author

Appreciate it, you and this project @akhoury !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants