Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

failed playlist creation causes constant warnings #160

Open
simon-weber opened this issue Jul 1, 2017 · 2 comments
Open

failed playlist creation causes constant warnings #160

simon-weber opened this issue Jul 1, 2017 · 2 comments
Labels

Comments

@simon-weber
Copy link
Owner

On a look through sentry I noticed one of the most frequent errors is from this line. It seems to be mostly from a handful of users where a playlist create failed, leaving an orphaned local autoplaylist that causes this warning on every sync.

I'm leaning towards just deleting the local autoplaylist rather than retrying to create the remote one. There is a chance this will delete a playlist people are using if we failed to persist the remote id, though it seems pretty slim.

@simon-weber simon-weber added the bug label Jul 1, 2017
@simon-weber simon-weber changed the title recover gracefully from failed playlist creation failed playlist creation causes constant warnings Jul 1, 2017
@simon-weber simon-weber mentioned this issue Jul 18, 2018
@simon-weber
Copy link
Owner Author

You know, it's probably better to detect this and put something in the UI so users can decide what to do about it. It's easy to manually fix (by just duplicating the playlist), and automating it could lead to all sorts of runaway situations (eg duplicating forever because something else is preventing creation).

@simon-weber
Copy link
Owner Author

This can also prevent syncing in cases where the failed autoplaylist gets linked:

background.js:11460 TypeError: Cannot read property 'localId' of undefined
    at Object.queryTracks (background.js:28051)
    at resolve (background.js:27892)
    at new Promise (<anonymous>)
    at getLinkedTracks (background.js:27891)
    at Promise.all.linkedPlaylistIds.map.id (background.js:27988)
...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant