Fix BackURL redirect with strict or lax session cookie security. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz
commented
Jan 10, 2024
| @@ -75,7 +75,8 @@ public function redirect(RequestHandler $requestHandler = null, HTTPRequest $req | |||
| $additionalGetQueryParams = $this->getAdditionalGETQueryParameters(); | |||
|
|
|||
| try { | |||
| $auth->login(Director::absoluteBaseURL() . 'saml/', $additionalGetQueryParams); | |||
There was a problem hiding this comment.
By the way, this usage of login's first parameter is wrong, it results in a URL like https://mysite.comsaml/, i.e. it's missing the slash. The bug didn't manifest as an issue, because RelayState isn't used anyway.
jareddreyerss
added a commit
that referenced
this pull request
Feb 27, 2024
See #55 PR for more context. This is merely a cherry pick / copy of that commit but for the 2 branch so in theory should work in SS 4.x
satrun77
pushed a commit
that referenced
this pull request
Feb 28, 2024
See #55 PR for more context. This is merely a cherry pick / copy of that commit but for the 2 branch so in theory should work in SS 4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #45
Needs cross-check, I only tested it on my SAML setup with Google Workspace.
Also, someone wearing a security hat should see if this is ok.