Page on this site form appears incorrectly on short windows

[sig-peggy]

Module version(s) affected

4.0.0

Description

When the browser window is shorter than the link form - most likely to happen with the 'Page on this site' option - then the modal background does not extend fully behind all of the fields.
Tested on Firefox and Chrome

How to reproduce

Make the browser window ~500px height or smaller and select the add a 'Page on this site' link. The modal that opens has a gap in the background between the part of the field that is visible within the browser window initially and the 'Create link' button. This makes any fields within that area difficult to see.

Possible Solution

No response

Additional Context

No response

Validations

• Check that there isn't already an issue that reports the same bug
• Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

[GuySartorelli]

Thanks for reporting that. It's not going to be a common scenario with the built-in link types but it would be easy to imagine a complex custom link with lots of fields which would exhibit this problem. Most likely there's an overflow:hidden or similar that just needs to be set to allow scrolling or an errant max-height somewhere.

If you'd like to submit a PR resolving this I'd be very happy to review it - alternatively it'll be added to the CMS Squad's backlog, and I can't make any promises about when it would be prioritised.