Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing Data #1

Closed
maxime-rainville opened this issue Nov 23, 2020 · 4 comments
Closed

Storing Data #1

maxime-rainville opened this issue Nov 23, 2020 · 4 comments
Assignees
Milestone

Comments

@maxime-rainville
Copy link

maxime-rainville commented Nov 23, 2020

Story

As a developer I want a sensible way to store link data so that I can implement a link management solution for my user.

Acceptance criteria

  • We have evaluated that the JSON and DataObject approach.
  • We've confirmed which one is the best.
  • We have evaluated the possibility of implementing the link filed in a generic way that allow other developers to use their own data store.
  • Which ever solution is picked, it most support the addition of custom link types.
  • Decision is recorded in subsequent cards for implementation.

Note

We've had issues in the past with the elemental data model. We explored using JSON fields instead of DataObject, but it's a bit clunky. We just need to validate that the DataObject approach won't have any unexpected downside.

@maxime-rainville
Copy link
Author

@chillu From our own experience and from talking to the terraformers, we're leaning towards dropping the "link data as JSON" idea and implement each link type as a subclass of a generic Link DataObject.

We'll probably want to have a catch up with you soonish to identify some of the potential pitfall with this approach.

@dnsl48 dnsl48 self-assigned this Nov 30, 2020
@brynwhyman brynwhyman added this to the Sprint 73 milestone Nov 30, 2020
@chillu
Copy link
Member

chillu commented Dec 11, 2020

Is it better to close this and continue the discussion in #30?

@dnsl48
Copy link

dnsl48 commented Dec 11, 2020

Yes, this one is rather the "actionable" card. We'll close it as a part of our sprint work soon.

@dnsl48
Copy link

dnsl48 commented Jan 8, 2021

RFC-30 is finalised and ready for sharing with the community and keeping all data-model related discussions in there.
This issue can be closed when silverstripe/silverstripe-framework#9817 gets merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants