GridField Filter Tags Remove Button does not clear GridState GridFieldFilterHeader Column

[scaventum]

Affected Version

4.4.4

Description

I have a model admin which automatically implements GridField for displaying the list. What i noticed is when i apply filter on one or more fields, the GridField search box will then show filter tags which is very informative and also removable with [x] button next to it (so you can easily remove the filter).

The problem is when remove the filter tags by clicking the [x] button and checked the request by inspect element (network tab), the filter is still not cleared.

Steps to Reproduce

1. Fresh install Silverstripe 4.4.4
2. Create a simple DataObject

use SilverStripe\ORM\DataObject;

class Player extends DataObject 
{
    private static $db = [
        'PlayerNumber' => 'Int',
        'FirstName' => 'Varchar(255)',
        'LastName' => 'Text',
        'Birthday' => 'Date'
    ];

private static $summary_fields = [
        'PlayerNumber' => 'Player Number',
        'FirstName' => 'First Name',
        'LastName' => 'Last Name',
    ];
}

3. Create simple ModelAdmin for that DataObject

use SilverStripe\Admin\ModelAdmin;

class MyAdmin extends ModelAdmin 
{

    private static $managed_models = [
        'Player'
    ];

    private static $url_segment = 'players';

    private static $menu_title = 'Player Admin';
}

4. Open the ModelAdmin from CMS /admin/players, open inspect element (network tab)
5. Filter the list by typing a keyword on FirstName field on top right, e.g. Bob
6. The filter tag in search box should show ( x | First Name: Bob)
7. Remove the filter tag by clicking (x)
8. Look at the recently created request after clicking (x):

MyProject-DataObjects-Region[GridState]:
{
   "GridFieldSortableHeader":{
      "SortColumn":[

      ]
   },
   "GridFieldFilterHeader":{
      "Columns":{
         "FirstName":"Bob"
      }
   },
   "GridFieldPaginator":{
      "currentPage":1,
      "itemsPerPage":30
   },
   "Readonly":[

   ]
}

The question is why the GridFieldFilerHeader still has the filter Bob. I realize the grid shows the correct list of data. But i think this could be a bug if we have some tweaks on custom filters.

[Cheddam]

Thanks for the report, @scaventum!

[sminnee]

FYI I've suggested building on #9190 to push grid field state into the URL via the history API, and have it be managed by GridField itself rather than selected components. This may assist with this.