Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the getDescription method from BaseElement #1106

Closed
GuySartorelli opened this issue Oct 9, 2023 · 0 comments
Closed

Remove the getDescription method from BaseElement #1106

GuySartorelli opened this issue Oct 9, 2023 · 0 comments
Labels
impact/medium type/api-break
Milestone
Cleanup later

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 9, 2023 •
edited
Loading

The getDescription method is potentially overriding a Description db field on any extending class.

The method was used only to get an addition to getTypeNice to display in the gridfield, possibly translated.

PRs
@GuySartorelli GuySartorelli added this to the Silverstripe CMS 6 milestone Oct 9, 2023
This was referenced May 10, 2024
Closed
Closed
@GuySartorelli GuySartorelli self-assigned this May 10, 2024
This was referenced May 28, 2024
Merged
Merged
@GuySartorelli GuySartorelli removed their assignment May 28, 2024
This was referenced Jun 10, 2024
Merged
Merged
@GuySartorelli GuySartorelli removed their assignment Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact/medium type/api-break
Projects
None yet
Milestone
Cleanup later
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli