Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove widgets #589

Closed
1 task done
chillu opened this issue Jun 25, 2019 · 3 comments
Closed
1 task done

Remove widgets #589

chillu opened this issue Jun 25, 2019 · 3 comments

Comments

@chillu
Copy link
Member

chillu commented Jun 25, 2019

There's a whole bunch of "widgets" which is our outdated way of doing blocks: https://github.com/silverstripe/silverstripe-blog/tree/master/src/Widgets

We don't have an equivalent replacement for this in elemental. Widgets are designed for a "sidebar" which should show up on every blog post. You can do this via https://github.com/dnadesign/silverstripe-elemental-virtual, but that's creating a lot of duplicate blocks, and needs to be configured again on every new blog post.

The concept of a configurable "sidebar" is kind of outdated. I think the baseline is giving devs the ability to add includes to their template for that functionality - since in most cases, they'll have to adjust the template anyway - take the silverstripe.org/blog for example, it has tags and categories.

In terms of widget types:

  • Archive: Kind of useful for month based browsing on large blogs
  • Categories and Tags: Should be a template addition? I don't think there's much value in a user-configurable limit and sort order
  • Featured and Recent Posts: I think that's actually a more generic use case for a block module that just lists pages in a parent?
  • Tag Cloud: I think we should drop support altogether, that can be a third party addition if anyone wants to recreate it...

Acceptance criteria

  • All code pertaining to widgets is removed in CMS 6

CMS 5 PRs

CMS 6 PRs

@GuySartorelli
Copy link
Member

This card is fairly old now, and I honestly doubt anyone is actually using the widgets. Most likely anyone who wants that functionality has already recreated it with elemental blocks. Widgets aren't even commercially supported in CMS 5, and we're gearing up for a CMS 6 release in just over half a year.

We should remove all of the widgets and call it a day.

@GuySartorelli
Copy link
Member

CMS 5 PRs merged. Reassigning to Steve for CMS 6 PRs

@GuySartorelli
Copy link
Member

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants