Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview docs have some incorrect or missing information. #96

Closed
3 tasks done
GuySartorelli opened this issue Oct 4, 2022 · 0 comments
Closed
3 tasks done

Preview docs have some incorrect or missing information. #96

GuySartorelli opened this issue Oct 4, 2022 · 0 comments
Assignees
@emteknetnz
Labels
complexity/medium impact/medium type/docs

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 4, 2022 •
edited
Loading

  • The preview docs as written will result in css and js from the CMS being injected into the preview if the preview HTML contains <head> or <body> tags.
  • There are some broken links in the 4 and 5 branches
  • The 4 and 5 branch docs haven't been fully updated to account for the recent changes (i.e. they still say it's dificult to implement CMSEditLink()

Acceptance criteria:

  • There are no broken links in preview docs
  • CSS and JS Requirements are accounted for
  • The 4 and 5 branches don't say it's difficult to implement CMSEditLink() anymore

PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emteknetnz emteknetnz

Labels
complexity/medium impact/medium type/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli