Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple source formats #38

Open
b3wii opened this issue Nov 5, 2019 · 2 comments
Open

Multiple source formats #38

b3wii opened this issue Nov 5, 2019 · 2 comments

Comments

@b3wii
Copy link

b3wii commented Nov 5, 2019

This:

<video class="vjs-tech" poster="31813vpo_565751d1bdc0c66.jpg" preload="metadata" crossorigin="anonymous">
	<source src="web.mp4" type="video/mp4" label="480p" selected="true">
	<source src="web.ogv" type="video/ogg" label="480p" selected="true">
	<source src="web.webm" type="video/webm" label="480p" selected="true">
	<source src="web_720p.mp4" type="video/mp4" label="720p">
	<source src="web_720p.ogv" type="video/ogg" label="720p">
	<source src="web_720p.webm" type="video/webm" label="720p">
	<source src="web_1080p.mp4" type="video/mp4" label="1080p">
	<source src="web_1080p.ogv" type="video/ogg" label="1080p">
	<source src="web_1080p.webm" type="video/webm" label="1080p">
</video>

..results in this:

https://i.imgur.com/s1oNq18.png (one select option for every source element)

@b3wii
Copy link
Author

b3wii commented Nov 5, 2019

For now i set src before calling player.controlBar.addChild('QualitySelector') but it would be nice if the script would check player.currentType() and only show those formats.

@jthomerson
Copy link
Member

@b3wii your assessment sounds correct. Pull requests are welcome. Please make sure to read and comply with out coding standards to ensure your PR has the best chance of success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants