Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transit UoPool from ONE chain with MULTIPLE entrypoint to ONE to ONE relationship #213

Open
zsluedem opened this issue Sep 21, 2023 · 3 comments
Labels
A-mempool Area: User operation mempool T-enhancement Type: Enhancement to existing feature

Comments

@zsluedem
Copy link
Collaborator

Currently the relationship between chain_id and entrypoint address woule be like one to multiple.
Like if we want to start a uopool service https://github.com/Vid201/silius/blob/main/crates/grpc/src/uopool.rs#L347-L359, we need to supply one chain and multiple entrypoints.

However, the real cases are more like one chain to one entrypoint relationship.

We should transit to one to one relationship.

@Vid201 Does that make sense?

@Vid201
Copy link
Member

Vid201 commented Sep 21, 2023

Currently the relationship between chain_id and entrypoint address woule be like one to multiple. Like if we want to start a uopool service https://github.com/Vid201/silius/blob/main/crates/grpc/src/uopool.rs#L347-L359, we need to supply one chain and multiple entrypoints.

However, the real cases are more like one chain to one entrypoint relationship.

We should transit to one to one relationship.

@Vid201 Does that make sense?

That's a good question. Generally, I agree with your suggestion. There should be only one entry point that is trusted and verified on each chain. The advantage that we can get with one chain and multiple entry point relationship is that we can support multiple version of entrypoints (example v0.7 and v0.8 ...) - of course in case the function signatures and things like that stay the same between these versions. I am not sure how this will play out in the future.

But at the moment, I guess it makes sense to make the change.

@zsluedem
Copy link
Collaborator Author

The thing is that one to one relationship could also cover multiple version of entrypoint here like 0.7 and 0.6 version for eth mainnet could be
Chain(eth) -> 0.6 version entrypoint
Chain(eth) -> 0.7 version entrypoint
although the Chain(eth) is duplicate here. But it would give us more flexibility

@Vid201
Copy link
Member

Vid201 commented Sep 22, 2023

The thing is that one to one relationship could also cover multiple version of entrypoint here like 0.7 and 0.6 version for eth mainnet could be Chain(eth) -> 0.6 version entrypoint Chain(eth) -> 0.7 version entrypoint although the Chain(eth) is duplicate here. But it would give us more flexibility

Ok, true. Then let's make a change!

@Vid201 Vid201 added T-enhancement Type: Enhancement to existing feature A-mempool Area: User operation mempool labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mempool Area: User operation mempool T-enhancement Type: Enhancement to existing feature
Projects
None yet
Development

No branches or pull requests

2 participants