Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink \latin-in-tate: if a font has a vrt2 feature, use it instead. #1190

Open
ctrlcctrlv opened this issue Aug 12, 2021 · 2 comments
Open
Labels
enhancement Software improvement or feature request

Comments

@ctrlcctrlv
Copy link
Member

vrt2, which stands for “Vertical Alternates and Rotation”, is a common OpenType feature available in professional CJK fonts that fulfills the same function as \latin-in-tate in a much cleaner way. It doesn't suffer from any of the placement bugs that \latin-in-tate does, either. I think, if it's available for all the characters the user is trying to shape, we should use it instead.

image
Text shaped above is SILE typesetter! SILE with vrt2 enabled.

@alerque alerque added the enhancement Software improvement or feature request label Aug 12, 2021
@alerque
Copy link
Member

alerque commented Aug 12, 2021

Sounds good to me. I do wonder about the overhead of scanning all characters on the font before shaping each string. Perhaps it would be better to just see if the font has any support when we first load it and default to using it if if does, with of course an override available for when that isn't sufficient.

@ctrlcctrlv
Copy link
Member Author

I was thinking \latin-in-tate itself would do the scan, not SILE in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Software improvement or feature request
Projects
Status: No status
Development

No branches or pull requests

2 participants