From 430332af137ebecc6542b1c01410da5bb3d5f041 Mon Sep 17 00:00:00 2001 From: Ashwin P Chandran Date: Wed, 2 Nov 2022 09:58:50 -0700 Subject: [PATCH] Enable visbuilder by default (#2725) * Enable visbuilder by default Signed-off-by: Ashwin P Chandran * Adds changelog entry Signed-off-by: Ashwin P Chandran Signed-off-by: Ashwin P Chandran Signed-off-by: David Sinclair --- CHANGELOG.md | 1 + config/opensearch_dashboards.yml | 2 +- src/plugins/vis_builder/config.ts | 2 +- src/plugins/vis_builder/server/index.ts | 3 --- test/common/config.js | 1 - test/functional/config.js | 2 +- 6 files changed, 4 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 149531bbd7fc..c6e1d7a8e37d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - [Vis Builder] Rename wizard to visBuilder in i18n id and formatted message id ([#2635](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2635)) - [Vis Builder] Rename wizard to visBuilder in class name, type name and function name ([#2639](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2639)) - [Vis Builder] Rename wizard on save modal and visualization table ([#2645](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2645)) +- [Vis Builder] Enable VisBuilder by default ([#2725](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2725)) - Change save object type, wizard id and name to visBuilder #2673 ([#2673](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2673)) - Add extension point in saved object management to register namespaces and show filter ([#2656](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2656)) - [Multi DataSource] Update MD data source documentation link ([#2693](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2693)) diff --git a/config/opensearch_dashboards.yml b/config/opensearch_dashboards.yml index d68c77ad8495..4d81b0b3be69 100644 --- a/config/opensearch_dashboards.yml +++ b/config/opensearch_dashboards.yml @@ -220,7 +220,7 @@ # for reducing the load of OpenSearch cluster. # data.search.usageTelemetry.enabled: false -# Set the value of this setting to true to start exploring wizard +# Set the value of this setting to false to disable VisBuilder # functionality in Visualization. # vis_builder.enabled: false diff --git a/src/plugins/vis_builder/config.ts b/src/plugins/vis_builder/config.ts index 79412f5c02ee..b6be3f718eea 100644 --- a/src/plugins/vis_builder/config.ts +++ b/src/plugins/vis_builder/config.ts @@ -6,7 +6,7 @@ import { schema, TypeOf } from '@osd/config-schema'; export const configSchema = schema.object({ - enabled: schema.boolean({ defaultValue: false }), + enabled: schema.boolean({ defaultValue: true }), }); export type ConfigSchema = TypeOf; diff --git a/src/plugins/vis_builder/server/index.ts b/src/plugins/vis_builder/server/index.ts index 417e6d2e317f..f04ba546623f 100644 --- a/src/plugins/vis_builder/server/index.ts +++ b/src/plugins/vis_builder/server/index.ts @@ -17,8 +17,5 @@ export function plugin(initializerContext: PluginInitializerContext) { export { VisBuilderPluginSetup, VisBuilderPluginStart } from './types'; export const config: PluginConfigDescriptor = { - exposeToBrowser: { - enabled: true, - }, schema: configSchema, }; diff --git a/test/common/config.js b/test/common/config.js index 0ad9dc042c5b..5db5748087a3 100644 --- a/test/common/config.js +++ b/test/common/config.js @@ -78,7 +78,6 @@ export default function () { `--opensearchDashboards.branding.mark.defaultUrl=https://opensearch.org/assets/brand/SVG/Mark/opensearch_mark_default.svg`, `--opensearchDashboards.branding.mark.darkModeUrl=https://opensearch.org/assets/brand/SVG/Mark/opensearch_mark_darkmode.svg`, `--opensearchDashboards.branding.applicationTitle=OpenSearch`, - `--vis_builder.enabled=true`, ], }, services, diff --git a/test/functional/config.js b/test/functional/config.js index d60250968720..9485225dc8ca 100644 --- a/test/functional/config.js +++ b/test/functional/config.js @@ -93,7 +93,7 @@ export default async function ({ readConfigFile }) { hash: '/', }, visBuilder: { - pathname: '/app/visBuilder', + pathname: '/app/vis-builder', hash: '/', }, dashboard: {