Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Integration failure: staging instance #889

Closed
github-actions bot opened this issue Feb 4, 2024 · 10 comments · Fixed by #891
Closed

[CI] Integration failure: staging instance #889

github-actions bot opened this issue Feb 4, 2024 · 10 comments · Fixed by #891
Assignees
Labels
bug Something isn't working component:cicd CI/CD component:tests Unit and integration tests

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2024

Staging instance failure

A scheduled test against Sigstore's staging instance has failed.

This suggests one of three conditions:

  • A backwards-incompatible change in a Sigstore component;
  • A regression in sigstore-python;
  • A transient error.

The full CI failure can be found here:

https://github.com/sigstore/sigstore-python/actions/runs/7772634242

@github-actions github-actions bot added bug Something isn't working component:cicd CI/CD component:tests Unit and integration tests labels Feb 4, 2024
@woodruffw woodruffw unassigned di Feb 4, 2024
@woodruffw
Copy link
Member

Context: this failed because we failed to parse the checkpoint record in Rekor's response.

Triaging: looks like Rekor 1.3.5 removed the timestamp field from the checkpoint: sigstore/rekor#1888

This should be trivial for us to fix, per convo in the PR above.

@woodruffw
Copy link
Member

Opened #891 for this.

@jku
Copy link
Member

jku commented Feb 4, 2024

Yes, even the "spec" on transparency-dev says:

The first 3 lines of the body MUST be present in all Checkpoints.

So we're not compliant when we require 4 lines.

@woodruffw
Copy link
Member

Yep, opened #891 with the fix.

@haydentherapper
Copy link
Contributor

Whoops, sorry that broke tests! Yea, the timestamp is part of extra data (which should be parsed, just not required), and it served no purpose in the ecosystem.

@woodruffw
Copy link
Member

No problem at all! This was definitely us not reading the spec closely enough 🙂

@jku
Copy link
Member

jku commented Feb 4, 2024

We should do a release in near future so we're ahead of this changing in production rekor.

@jku jku closed this as completed in #891 Feb 4, 2024
@woodruffw
Copy link
Member

We should do a release in near future so we're ahead of this changing in production rekor.

Yeah, agreed. We're mid-burn for 3.0, so we may have to cut another 2.x release and backport this.

@woodruffw
Copy link
Member

I've created https://github.com/sigstore/sigstore-python/tree/series/2.1.x to track a point release to 2.1.x.

@woodruffw
Copy link
Member

I've cut 2.1.2 as a backport release. We can continue to use series/2.1.x for further releases on that line 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:cicd CI/CD component:tests Unit and integration tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants