Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce our dependency on ambient OIDC tests for error cases #570

Closed
woodruffw opened this issue Mar 17, 2023 · 0 comments · Fixed by #576
Closed

Reduce our dependency on ambient OIDC tests for error cases #570

woodruffw opened this issue Mar 17, 2023 · 0 comments · Fixed by #576
Assignees
Labels
enhancement New feature or request

Comments

@woodruffw
Copy link
Member

Our ambient OIDC tests consistently catch regressions, but they only run on first-party merges and PRs. As such, they tend to catch regressions after they make it to main.

We should reduce our dependency on the ambient OIDC credential in some of our error testcases. In particular, things like SCT error case handling should be test-able offline, since we can store the SCT as a test asset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants